fix(agent): guard missing verbose on headless args#535
Merged
dwash96 merged 1 commit intoMay 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrightVision and other headless callers use
Coder.create(..., args=SimpleNamespace(...))viabright_vision_core.headless_args.default_headless_args(), which did not always define every flag the interactive CLI sets.AgentCoder.initialize_mcp_tools()accessedself.args.verboseunconditionally, which raised:AttributeError: 'types.SimpleNamespace' object has no attribute 'verbose'when users ran
/agentthrough the Vision HTTP API.This change uses
getattr(self.args, "verbose", False)(and treats missingargsas false), matching the pattern already used incecli/commands/run.py.Not in scope
/addattachment staging paths (fix/add-attachment-staging-paths)Test plan
python -m pytest tests/core/test_headless_agent.py -q(BrightVision, withsource activate.sh)E2E_LLM=1 python -m pytest tests/core/test_agent_llm.py -q(optional, needs Ollama)yarn tauri dev→ Terminal Start → chat/agentshort prompt → noverboseerror in chat/terminal